Skip to content

Conversation

samrooke
Copy link
Collaborator

@samrooke samrooke commented Sep 15, 2022

Search for existing workflow instances using the origin AE title

A few sentences describing the changes proposed in this pull request.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@samrooke samrooke marked this pull request as draft September 15, 2022 09:26
@samrooke samrooke force-pushed the jsparkes/AC-400-origin-ae-title branch from f7c7388 to dbd07c1 Compare September 15, 2022 13:03
@samrooke samrooke marked this pull request as ready for review September 15, 2022 13:04
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #420 (b6e1744) into develop (4919d32) will decrease coverage by 0.03602%.
The diff coverage is 44.44444%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #420         +/-   ##
===================================================
- Coverage   58.97206%   58.93604%   -0.03603%     
===================================================
  Files            135         135                 
  Lines          16713       16730         +17     
  Branches        1735        1736          +1     
===================================================
+ Hits            9856        9860          +4     
- Misses          6544        6558         +14     
+ Partials         313         312          -1     
Flag Coverage Δ
unittests 58.93604% <44.44444%> (-0.03603%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...anager/Database/Repositories/WorkflowRepository.cs 0.00000% <0.00000%> (ø)
...rkflowExecuter/Services/WorkflowExecuterService.cs 70.02288% <91.66667%> (+0.63035%) ⬆️
...ter.Tests/Services/WorkflowExecuterServiceTests.cs 100.00000% <100.00000%> (ø)
...ins/AideClinicalReview/AideClinicalReviewPlugin.cs 76.52174% <0.00000%> (-3.47827%) ⬇️
...vices/DataRetentionService/DataRetentionService.cs 91.17647% <0.00000%> (-2.94119%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4919d32...b6e1744. Read the comment docs.

RemakingEden and others added 4 commits September 15, 2022 14:30
Signed-off-by: Joss Sparkes <joss.sparkes@gmail.com>
Signed-off-by: Sam Rooke <sam.rooke@answerdigital.com>
…itle to ensure it is agnostic

Signed-off-by: Joss Sparkes <joss.sparkes@gmail.com>
Signed-off-by: Sam Rooke <sam.rooke@answerdigital.com>
Signed-off-by: Sam Rooke <sam.rooke@answerdigital.com>
Signed-off-by: Sam Rooke <sam.rooke@answerdigital.com>
@samrooke samrooke force-pushed the jsparkes/AC-400-origin-ae-title branch from dbd07c1 to 9e43173 Compare September 15, 2022 13:31
@jackschofield23
Copy link
Contributor

I Think that we may need to ensure that the Calling AE Title exists, as that should always be included.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@neildsouth neildsouth merged commit 5288343 into develop Sep 16, 2022
@samrooke samrooke deleted the jsparkes/AC-400-origin-ae-title branch September 16, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants