Skip to content

Conversation

jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Sep 15, 2022

Signed-off-by: Jack Schofield jack.schofield@answerdigital.com

Description

Fixes #421 .

Fixes empty name in workflow validation failing.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #422 (98ddfde) into develop (ea7e678) will increase coverage by 0.01549%.
The diff coverage is 57.14286%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #422         +/-   ##
===================================================
+ Coverage   58.92665%   58.94214%   +0.01548%     
===================================================
  Files            135         135                 
  Lines          16714       16713          -1     
  Branches        1734        1735          +1     
===================================================
+ Hits            9849        9851          +2     
+ Misses          6556        6550          -6     
- Partials         309         312          +3     
Flag Coverage Δ
unittests 58.94214% <57.14286%> (+0.01548%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/PayloadListener/Extensions/WorkflowExtensions.cs 77.27273% <57.14286%> (-3.32429%) ⬇️
...vices/DataRetentionService/DataRetentionService.cs 94.11765% <0.00000%> (+2.94118%) ⬆️
...ug-ins/Argo/Repositories/ArgoMetadataRepository.cs 79.06977% <0.00000%> (+9.30233%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea7e678...98ddfde. Read the comment docs.

@jackschofield23 jackschofield23 marked this pull request as ready for review September 15, 2022 14:18
@jackschofield23 jackschofield23 force-pushed the workflow-validation-error branch from 5ff9c66 to 3e6af4b Compare September 15, 2022 14:19
Copy link
Collaborator

@neildsouth neildsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the number of warnings is creeping up again :)

Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23 jackschofield23 force-pushed the workflow-validation-error branch from 3e6af4b to 98ddfde Compare September 16, 2022 10:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.5% 76.5% Coverage
0.0% 0.0% Duplication

@jackschofield23 jackschofield23 merged commit 4919d32 into develop Sep 16, 2022
@RemakingEden RemakingEden deleted the workflow-validation-error branch September 16, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow Validation - Top Level Fields Throws 500

2 participants