Skip to content

Conversation

RemakingEden
Copy link
Member

@RemakingEden RemakingEden commented Sep 16, 2022

Signed-off-by: RemakingEden joss.sparkes@gmail.com

Description

We have an code coverage checking some files that cannot be tested. It is causing a holdup in PR's. We also have codecov which seems to do the same thing as sonarscanner so i have removed it.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
@RemakingEden RemakingEden changed the title Added repos to code cov exclude list Add untestable paths to code coverage exclusions Sep 16, 2022
Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
@RemakingEden RemakingEden changed the title Add untestable paths to code coverage exclusions Add untestable paths to code coverage exclusions an remove codecov Sep 16, 2022
@RemakingEden RemakingEden marked this pull request as ready for review September 16, 2022 13:18
@Project-MONAI Project-MONAI deleted a comment from codecov bot Sep 16, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@RemakingEden RemakingEden merged commit f562fe6 into develop Sep 16, 2022
@RemakingEden RemakingEden deleted the jsparkes/exclude-from-codecoverage branch September 16, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants