Skip to content

Conversation

jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Sep 20, 2022

Signed-off-by: Jack Schofield jack.schofield@answerdigital.com

Description

Fixes # .

add multiple conditions to task destinations.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23 jackschofield23 marked this pull request as ready for review September 20, 2022 14:57
@RemakingEden
Copy link
Member

@jackschofield23 Did we decide all testing for this was going to be done in unit tests?

Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

71.1% 71.1% Coverage
0.0% 0.0% Duplication

Copy link
Member

@RemakingEden RemakingEden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM

@jackschofield23 jackschofield23 merged commit 37a89b0 into develop Sep 21, 2022
@jackschofield23 jackschofield23 deleted the jschofield/multiple-conditions branch September 21, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants