Skip to content

Conversation

jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Sep 22, 2022

Signed-off-by: Jack Schofield jack.schofield@answerdigital.com

Description

Fixes #433 .

fixes the workflow validation error that returned a 500

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@RemakingEden RemakingEden force-pushed the jschofield/fix-workflow-validation branch from c0908b8 to c03ab3f Compare September 22, 2022 09:19
@jackschofield23 jackschofield23 force-pushed the jschofield/fix-workflow-validation branch from c03ab3f to 54d4162 Compare September 22, 2022 09:21
@jackschofield23 jackschofield23 marked this pull request as ready for review September 22, 2022 09:23
Copy link
Member

@RemakingEden RemakingEden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackschofield23 jackschofield23 force-pushed the jschofield/fix-workflow-validation branch from e0d25ee to 0e8f74d Compare September 22, 2022 10:27
jackschofield23 and others added 4 commits September 22, 2022 11:28
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23 jackschofield23 force-pushed the jschofield/fix-workflow-validation branch from 0e8f74d to 8877c5f Compare September 22, 2022 10:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@RemakingEden RemakingEden merged commit 302c05c into develop Sep 22, 2022
@RemakingEden RemakingEden deleted the jschofield/fix-workflow-validation branch September 22, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

500 returned with invalid body for PUT & POST workflows

2 participants