Skip to content

Conversation

lillie-dae
Copy link
Collaborator

Description

Fixes Invalid Id in workflow instances controller payloadId parameter being invalid should return 400 and message.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
…oy-workflow-manager into AC-579-invalid-id-in-workflowinstances-payloadid-payloadid-does-not-return-400-441
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
@RemakingEden
Copy link
Member

RemakingEden commented Sep 23, 2022

@lillie-dae the initial issue is fixed. It seems that the fix for the initial issue has broken some other functionality. We are getting a lot of the get all's returning 400.

RemakingEden and others added 5 commits September 23, 2022 15:39
Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@lillie-dae lillie-dae merged commit c7ce726 into develop Sep 28, 2022
@mocsharp mocsharp deleted the AC-579-invalid-id-in-workflowinstances-payloadid-payloadid-does-not-return-400-441 branch June 11, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants