Skip to content

Conversation

RemakingEden
Copy link
Member

Signed-off-by: RemakingEden joss.sparkes@gmail.com

Description

We've had a few issues where our tests have not checked the error strings and the tests has passed because it is failing for a different reason. We had tests with this error string check but it wasnt on all so I have added it to all.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • All tests passed locally.

Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@RemakingEden RemakingEden merged commit d37ab99 into develop Sep 28, 2022
@RemakingEden RemakingEden deleted the jsparkes/add-error-checking-to-400-tests branch September 28, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants