only use dcm files for export #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackschofield23
force-pushed
the
jschofield/export-fix
branch
from
dab5ef4 to
a4b7481
Compare
jackschofield23
force-pushed
the
jschofield/export-fix
branch
from
a4b7481 to
55e5086
Compare
neildsouth
reviewed
Sep 29, 2022
src/WorkflowManager/WorkflowExecuter/Services/WorkflowExecuterService.cs
Show resolved
Hide resolved
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
jackschofield23
force-pushed
the
jschofield/export-fix
branch
from
55e5086 to
73a2d7e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
neildsouth
approved these changes
Sep 29, 2022
mocsharp
reviewed
Sep 29, 2022
| true); | ||
| if (objects.IsNullOrEmpty() is false) | ||
|
|
||
| var dcmFiles = objects?.Where(o => o.FilePath.EndsWith(".dcm"))?.ToList(); |
There was a problem hiding this comment.
Sometimes, users may not use .dcm extension.
There was a problem hiding this comment.
Does this change also removes the ability to export HL7/FHIR?
There was a problem hiding this comment.
Do we know what other file extensions we will support?
There was a problem hiding this comment.
Currently we only support exporting to the dicom scu endpoint. So when we extend the export to other endpoints we can update supported filetypes.
There was a problem hiding this comment.
We will need to support DICOM, FHIR, and HL7 but no guarantee what file extensions users will use. Therefore, I think we must document the usage, e.g., without .dcm we will not export their DICOM files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jack Schofield jack.schofield@answerdigital.com
Description
Fixes # .
Only submits dicom files for export.
Now fails task and workflow if there are no files to export.
Status
Ready
Types of changes