AC-568-add-acknowledge-date-to-filter-out-previous-acknowledged-errors-monai #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
…oy-workflow-manager into AC-568-add-acknowledge-date-to-filter-out-previous-acknowledged-errors-monai
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
mocsharp
reviewed
Sep 29, 2022
src/WorkflowManager/WorkflowManager/Controllers/WorkflowInstanceController.cs
Outdated
Show resolved
Hide resolved
mocsharp
reviewed
Sep 29, 2022
...ionTests/WorkflowExecutor.IntegrationTests/StepDefinitions/WorkflowInstanceStepDefintions.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
…oy-workflow-manager into AC-568-add-acknowledge-date-to-filter-out-previous-acknowledged-errors-monai
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
neildsouth
approved these changes
Oct 3, 2022
…-previous-acknowledged-errors-monai
|
Kudos, SonarCloud Quality Gate passed! |
mocsharp
deleted the
AC-568-add-acknowledge-date-to-filter-out-previous-acknowledged-errors-monai
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lillie Dae lillie.dae@answerdigital.com
Description
This should be a new endpoint to return failed workflows, that have an empty value of
acknowledgedWorkflowErrors: null
at the workflow level.
The filter should return all failed workflows since the date. If the date format is invalid a 400 bad request should be returned.
ENDPOINT:
workflowsinstances/failed?acknowledged=2022-02-21
Status
Ready
Types of changes