Skip to content

Updated CR boolean logic #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Updated CR boolean logic #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09903c1
Updated CR boolean logic
JoeBatt1989 Apr 17, 2023
2ecabe9
Updated
JoeBatt1989 Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/TaskManager/Plug-ins/AideClinicalReview/AideClinicalReviewPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,13 @@ private void Initialize()
_workflowName = Event.TaskPluginArguments[Keys.WorkflowName];
}

if (Event.TaskPluginArguments.ContainsKey(Keys.Notifications))
if (Boolean.TryParse(Event.TaskPluginArguments[Keys.Notifications], out bool result))
{
_notifications = Boolean.TryParse(Event.TaskPluginArguments[Keys.Notifications], out bool result);
_notifications = result;
}
else
{
_notifications = true;
}

if (Event.TaskPluginArguments.ContainsKey(Keys.ReviewedExecutionId))
Expand Down
7 changes: 3 additions & 4 deletions tests/IntegrationTests/TaskManager.IntegrationTests/Support/Assertions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,11 @@ public void AssertClinicalReviewEvent(ClinicalReviewRequestEvent clinicalReviewR
clinicalReviewRequestEvent.PatientMetadata.PatientName.Should().Be(GetTaskPluginArguments(taskDispatchEvent, "patient_name"));
clinicalReviewRequestEvent.PatientMetadata.PatientSex.Should().Be(GetTaskPluginArguments(taskDispatchEvent, "patient_sex"));
clinicalReviewRequestEvent.PatientMetadata.PatientDob.Should().Be(GetTaskPluginArguments(taskDispatchEvent, "patient_dob"));
try
if (Boolean.TryParse(GetTaskPluginArguments(taskDispatchEvent, "notifications"), out bool result))
{
var notifications = GetTaskPluginArguments(taskDispatchEvent, "notifications");

clinicalReviewRequestEvent.Notifications.Should().Be(result);
}
catch (Exception ex)
else
{
clinicalReviewRequestEvent.Notifications.Should().Be(true);
}
Expand Down