Skip to content

Conversation

@neildsouth
Copy link
Member

Description

the set outputs function was saving the outputs to the workflow instance, but then a later DB call was overwriting them

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@neildsouth neildsouth merged commit 449e557 into develop Nov 3, 2023
@neildsouth neildsouth deleted the nds-fix-externalAppOutputs branch November 3, 2023 12:52
@mocsharp mocsharp modified the milestones: 0.1.30, 0.2.0 Jun 6, 2024
@mocsharp mocsharp added the bug Something isn't working label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants