-
Notifications
You must be signed in to change notification settings - Fork 769
Update modules notebooks to match format requirements #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nic Ma <nma@nvidia.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
|
In http://rsnachallenges.cloudapp.net/competitions/4 isn't working for me. |
|
In |
|
In Can it be merged with Thanks |
|
In |
|
In |
|
In If you use the MedNIST dataset, please acknowledge the source, e.g. |
|
In |
|
In And the RSNA links is invalid |
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
|
Hi @mingxin-zheng , Thanks for your suggestion, I think we need fixed version of ITK in this tutorial, so I didn't change it. |
Signed-off-by: Nic Ma <nma@nvidia.com>
|
Hi @mingxin-zheng , I have updated the PR according to all your comments. Thanks for the review. |
|
Hi @Nic-Ma , can you try to merge the main branch and see if the relevant notebooks in the PR can pass copyright and guideline tests? Thanks! |
I don't see error related to this PR. Thanks. |
|
Hi @Nic-Ma , thanks for the update. I think the pep8 test shows there is an import error in the |
Signed-off-by: Nic Ma <nma@nvidia.com>
|
@Nic-Ma a minor fix is needed here: I don't see any other issues. Please feel free to merge after the fix if there is no more pep8 failures |
Signed-off-by: Nic Ma <nma@nvidia.com>
…1156) ### Description This PR updated several modules tutorials to match the format requirements of contribution guideline. CC @mingxin-zheng . ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [x] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` Signed-off-by: Nic Ma <nma@nvidia.com>
Description
This PR updated several modules tutorials to match the format requirements of contribution guideline.
CC @mingxin-zheng .
Checks
./figurefolder./runner.sh -t <path to .ipynb file>