update error explanation in parameters fold in tutorials train_controlnet.ipynb #1974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Member
|
Hi @Can-Zhao I think this something you've worked on, can you please review these changes? Thanks! |
Contributor
Author
|
Sorry, I saw the error in auto check and it's about installing dependencies, I don't know how to fix it. |
ericspod
approved these changes
Apr 25, 2025
Member
|
Hi @MaybeRichard We're good to go here if you could please fix the DCO issue. |
Contributor
Author
|
ok, I already fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
The current documentation incorrectly states that "fold 0 is used for training" in the prepare_maisi_controlnet_json_dataloader function. In reality, the function uses the fold parameter to determine the validation set based on matching fold indices. Specifically, if a dataset item's fold value matches the fold value specified in config_maisi_controlnet_train.json, it is assigned to the validation set; otherwise, it is used for training.
Changes
Updated Documentation:
Revised the description of the fold parameter to accurately reflect its functionality.
Clarified that in the current parameter settings, fold 0 is designated for validation and fold 1 is designated for training.