-
Notifications
You must be signed in to change notification settings - Fork 771
Fix omniverse integration notebook #1980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the omniverse integration notebook and utility module to support recent changes in the Omniverse workflow, including adding materials for each mesh and updating documentation to reflect the deprecation of the Omniverse Launcher.
- Introduces random color material generation and binding in the mesh conversion utility.
- Updates the notebook content to provide instructions for using USD Composer instead of the deprecated Omniverse Launcher.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/omniverse/utility.py | Added material processing using UsdShade with random colors, and updated mesh iteration logic |
| modules/omniverse/omniverse_integration.ipynb | Revised markdown content to update instructions related to scene conversion and viewer usage |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the omniverse integration notebook and corresponding utility script to enhance the USD conversion process by adding material generation for each mesh and updating the notebook comments regarding the Omniverse integration.
- Added material creation with random colors for each mesh in the utility module.
- Updated text in the notebook to reflect the deprecation of the Omniverse Launcher and provide new instructions using the kit-app-template.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/omniverse/utility.py | Added material creation for each mesh and refactored mesh processing logic. |
| modules/omniverse/omniverse_integration.ipynb | Updated documentation text and file references to reflect the new integration process. |
Fixes # .
Description
Checks
./figurefolder./runner.sh -t <path to .ipynb file>