Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Apr 18, 2025

Fixes # .

Description

  • Add material for each mesh
  • update comment to using kit template instead of Usd Composer as omniverse launcher has been deprecated

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

KumoLiu added 2 commits April 18, 2025 17:33
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

KumoLiu and others added 2 commits April 18, 2025 18:52
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the omniverse integration notebook and utility module to support recent changes in the Omniverse workflow, including adding materials for each mesh and updating documentation to reflect the deprecation of the Omniverse Launcher.

  • Introduces random color material generation and binding in the mesh conversion utility.
  • Updates the notebook content to provide instructions for using USD Composer instead of the deprecated Omniverse Launcher.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
modules/omniverse/utility.py Added material processing using UsdShade with random colors, and updated mesh iteration logic
modules/omniverse/omniverse_integration.ipynb Revised markdown content to update instructions related to scene conversion and viewer usage

KumoLiu and others added 3 commits April 18, 2025 19:03
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu requested a review from Copilot April 18, 2025 11:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the omniverse integration notebook and corresponding utility script to enhance the USD conversion process by adding material generation for each mesh and updating the notebook comments regarding the Omniverse integration.

  • Added material creation with random colors for each mesh in the utility module.
  • Updated text in the notebook to reflect the deprecation of the Omniverse Launcher and provide new instructions using the kit-app-template.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
modules/omniverse/utility.py Added material creation for each mesh and refactored mesh processing logic.
modules/omniverse/omniverse_integration.ipynb Updated documentation text and file references to reflect the new integration process.

@ericspod ericspod merged commit 84c0a07 into main Apr 19, 2025
6 checks passed
@ericspod ericspod deleted the fix-omniverse branch April 19, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants