clean up

Author: clfhhc

readme.md

@@ -462,4 +462,4 @@
 1. NextJs, next-pwa, workbox are still growing their api, so this project setup will be modified in the future for easier setup.
 2. There is a known error on the workbox: https://github.com/GoogleChrome/workbox/issues/2178.
 3. The `subdomainPrefix` config is based on the unapproved pr https://github.com/shadowwalker/next-pwa/pull/33.
-4. All indirect children in `next/head` will not be picked up at build time, so all `next/link` wrapped elements must be inserted after the `next/head` is loaded.
+4. Only direct children in `next/head` will be picked up at build time, so all `next/link` wrapped elements must be inserted (useEffect) after the `next/head` is loaded.

src/features/head/ManifestHead.tsx

@@ -43,46 +43,6 @@ const ManifestHead: FC<Props> = ({
   isAmp,
   children,
 }) => {
-  // const linkToAdd: Record<string, { [key in string]: string }> = {};
-  // if (hrefManifest) {
-  //   linkToAdd.manifest = { href: join(linkPrefix, hrefManifest) };
-  // }
-  // if (!isAmp && hrefCanonical) {
-  //   linkToAdd.canonical = { href: join(linkPrefix, hrefCanonical) };
-  // }
-  // if (favIconPath) {
-  //   linkToAdd['shortcut icon'] = { href: join(linkPrefix, favIconPath) };
-  // }
-  // if (appleIconPath) {
-  //   linkToAdd['apple-touch-icon'] = {
-  //     href: join(linkPrefix, appleIconPath),
-  //     sizes: appleIconSize,
-  //   };
-  // }
-
-  // useEffect(() => {
-  //   const linkTags = Object.entries(linkToAdd).map(([rel, attrs]) => {
-  //     const tag = document.createElement('link');
-  //     tag.setAttribute('rel', rel);
-  //     Object.keys(attrs).forEach((attr) => {
-  //       tag.setAttribute(attr, attrs[attr]);
-  //     });
-  //     return tag;
-  //   });
-  //   const headElement = document.getElementsByTagName('head').item(0);
-  //   linkTags.forEach((tag) => {
-  //     if (headElement) {
-  //       headElement.appendChild(tag);
-  //     }
-  //   });
-  //   return () => {
-  //     linkTags.forEach((tag) => {
-  //       if (headElement) {
-  //         headElement.removeChild(tag);
-  //       }
-  //     });
-  //   };
-  // }, []);
   return (
     <NextHead>
       <title key="title">{title}</title>