Make path parameters more generic #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of taking
&[&str], this refactors most path parameters to takeimpl Iterator<Item = impl AsRef<str>>. This should make it possible to pass owned containers (e.g.Vecs or arrays), including those containing ownedStrings.While this seems to be the suggested approach for passing strings generically, it significantly impairs readability and introduces some ambiguities when passing empty paths (previously
&[]would have been accepted, which is now ambiguous due to the genericimpl AsRef<str>).Draft PR for now until we figure out a more acceptable tradeoff.