Set Up Casbin RBAC Foundation with DB Table, Model, Policies, and Tests #135

avirajsingh7 · 2025-04-10T14:15:18Z

Target issue is #131

This PR lays the foundation for implementing Role-Based Access Control (RBAC) using Casbin. It introduces the core components needed for flexible and scalable permission management across organizations and projects.

Database Table

Introduced casbin_rule table via Alembic migration.
Structured to support:
- p (policy rules)
- g (org-level role assignments)
- g2 (project-level role assignments)

Policy Loader

Utility function update_casbin_policies to load policies from a JSON file.
JSON-driven policy structure for clarity and maintainability.
Integrated as a data migration to seed policies on setup.

Casbin Integration

Basic rbac_model.conf model for supporting multi-level RBAC (org and project).
Casbin Enforcer and adapter initialization.
Policy auto-save enabled and policy loading during app startup via lifespan.

Initial Policies

Organization-Level Roles

Role	Permissions	Inherits Project Role
`org_reader`	Read-only access to org data	`project_reader`
`org_writer`	Read, Create and Update org data	`project_writer`
`org_admin`	Full access (read, write, delete)	`project_admin`

Organizational roles automatically inherit the equivalent project-level roles across all projects in that organization.

Project-Level Roles

Role	Permissions
`project_reader`	Read-only access to project data
`project_writer`	Read, Create and Update project data
`project_admin`	Full access (read, write, delete)

Tests

Introduced basic test suite (test_rbac.py) to validate policy enforcement.
Covers multiple users across different orgs and projects with various roles.

Checklist

Before submitting a pull request, please ensure that you mark these task.

Ran fastapi run --reload app/main.py or docker compose up in the repository root and test.
If you've fixed a bug or added code that is tested and has test cases.

This pull request introduces the foundational setup for Casbin Role-Based Access Control (RBAC) within the ProjectTech4DevAI/ai-platform repository. The changes include the addition of a Casbin rule table with appropriate columns and index, as well as initial Casbin policies through an Alembic migration, focusing on RBAC policy updates from a JSON file. A new RBAC model configuration file is introduced, defining roles and matcher logic, although it lacks error handling and documentation. The Casbin RBAC implementation is integrated into the FastAPI app, with lifespan management included. Additionally, the CasbinRule model is added for RBAC policy rules, and the import for access control management is updated. The pull request also includes a function to update Casbin policies from a JSON file.

kodus-ai · 2025-04-10T14:15:33Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

backend/app/alembic/utils.py

backend/app/alembic/versions/fc2d7ddfa265_add_intial_casbin_policies.py

backend/app/core/rbac/rbac_policies.json

backend/app/models/casbin_rule.py

kodus-ai · 2025-04-10T14:51:01Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

codecov · 2025-04-10T14:52:46Z

Codecov Report

Attention: Patch coverage is 99.47644% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
backend/app/core/rbac/update_casbin_policies.py	97.50%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

kodus-ai · 2025-04-10T14:55:30Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kodus-ai · 2025-04-10T15:03:22Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kodus-ai · 2025-04-17T05:19:59Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

backend/app/core/rbac/update_casbin_policies.py

kodus-ai · 2025-04-17T05:35:02Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kodus-ai · 2025-04-17T05:55:00Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

backend/scripts/prestart.sh

kodus-ai · 2025-04-17T10:51:20Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

AkhileshNegi · 2025-06-05T06:39:38Z

Closing this for now as it is not a priority for now, Will come back to it later

avirajsingh7 added 13 commits April 10, 2025 16:17

intial setup for rbac

fa613a4

enforcer for testing

db5db53

fix import

740ae71

matcher improved

c3bd485

fix migration

19e6c69

Added rbac policies

07367f0

rename rbac.py to casbin.py

d8d3879

update doc string in casbin table

84a643a

Added test cases for permission check

45d2b6a

remove crud from project file

2f77ed0

edited doc string

b0bc7fc

edited doc string in casbin rule

967e555

format file using precomit

a5c18b0

kodus-ai bot reviewed Apr 10, 2025

View reviewed changes

backend/app/alembic/utils.py Outdated Show resolved Hide resolved

kodus-ai bot reviewed Apr 10, 2025

View reviewed changes

backend/app/alembic/utils.py Outdated Show resolved Hide resolved

kodus-ai bot reviewed Apr 10, 2025

View reviewed changes

backend/app/alembic/utils.py Outdated Show resolved Hide resolved

kodus-ai bot reviewed Apr 10, 2025

View reviewed changes

backend/app/alembic/versions/fc2d7ddfa265_add_intial_casbin_policies.py Outdated Show resolved Hide resolved

kodus-ai bot reviewed Apr 10, 2025

View reviewed changes

backend/app/core/rbac/rbac_policies.json Show resolved Hide resolved

kodus-ai bot reviewed Apr 10, 2025

View reviewed changes

backend/app/models/casbin_rule.py Show resolved Hide resolved

kodus-ai bot reviewed Apr 10, 2025

View reviewed changes

backend/app/models/casbin_rule.py Show resolved Hide resolved

avirajsingh7 added 2 commits April 10, 2025 20:12

file handling for json policies

ae05921

precommit formatting

b165697

avirajsingh7 requested review from AkhileshNegi, jerome-white, nishika26 and sourabhlodha April 10, 2025 14:45

remove unused import

864d2c7

addes script to update casbin policies of p type

be598d1

kodus-ai bot reviewed Apr 17, 2025

View reviewed changes

backend/app/core/rbac/update_casbin_policies.py Outdated Show resolved Hide resolved

kodus-ai bot reviewed Apr 17, 2025

View reviewed changes

backend/app/core/rbac/update_casbin_policies.py Show resolved Hide resolved

format file using precommit

e63f989

update prestart script

cf54b17

kodus-ai bot reviewed Apr 17, 2025

View reviewed changes

backend/scripts/prestart.sh Show resolved Hide resolved

avirajsingh7 added 2 commits April 17, 2025 11:33

update test cases to have policies

778a708

added test cases for script for updating casbin policies

7cc74c7

precommit format file

6d8ce28

AkhileshNegi closed this Jun 5, 2025

AkhileshNegi deleted the feature/rbac branch October 13, 2025 13:27

Uh oh!

Set Up Casbin RBAC Foundation with DB Table, Model, Policies, and Tests #135

Set Up Casbin RBAC Foundation with DB Table, Model, Policies, and Tests #135

Uh oh!

Conversation

avirajsingh7 commented Apr 10, 2025 • edited by kodus-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Database Table

Policy Loader

Casbin Integration

Initial Policies

Organization-Level Roles

Project-Level Roles

Tests

Checklist

Uh oh!

kodus-ai bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kodus-ai bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

codecov bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kodus-ai bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kodus-ai bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kodus-ai bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

Uh oh!

kodus-ai bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kodus-ai bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

kodus-ai bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

AkhileshNegi commented Jun 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

avirajsingh7 commented Apr 10, 2025 •

edited by kodus-ai bot

Loading

kodus-ai bot commented Apr 10, 2025 •

edited

Loading

kodus-ai bot commented Apr 10, 2025 •

edited

Loading

codecov bot commented Apr 10, 2025 •

edited

Loading

kodus-ai bot commented Apr 10, 2025 •

edited

Loading

kodus-ai bot commented Apr 10, 2025 •

edited

Loading

kodus-ai bot commented Apr 17, 2025 •

edited

Loading

kodus-ai bot commented Apr 17, 2025 •

edited

Loading

kodus-ai bot commented Apr 17, 2025 •

edited

Loading

kodus-ai bot commented Apr 17, 2025 •

edited

Loading