Skip to content

Conversation

@avirajsingh7
Copy link
Collaborator

Summary

Target issue #216

This PR introduces a new Pydantic schema, StartThreadRequest, used to validate and structure incoming request data for the /thread/start endpoint.

Changes:
Added StartThreadRequest schema with the following fields:

  • question (str): the user's query
  • assistant_id (str): the OpenAI assistant ID
  • remove_citation (bool): flag to control citation behavior (default False)

Checklist

Before submitting a pull request, please ensure that you mark these task.

  • Ran fastapi run --reload app/main.py or docker compose up in the repository root and test.
  • If you've fixed a bug or added code that is tested and has test cases.

@avirajsingh7 avirajsingh7 self-assigned this Jun 20, 2025
@avirajsingh7 avirajsingh7 added bug Something isn't working ready-for-review labels Jun 20, 2025
@avirajsingh7 avirajsingh7 moved this to In Progress in Dev Priorities Jun 20, 2025
@avirajsingh7 avirajsingh7 linked an issue Jun 20, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
backend/app/api/routes/threads.py 87.50% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@AkhileshNegi AkhileshNegi merged commit d8e5a27 into main Jun 21, 2025
2 checks passed
@AkhileshNegi AkhileshNegi deleted the fix/thread_start branch June 21, 2025 05:01
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Dev Priorities Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready-for-review

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

threads/start doesn't throw a clear validation error

3 participants