Skip to content

Conversation

@nishika26
Copy link
Collaborator

@nishika26 nishika26 commented Jun 30, 2025

Summary

Target issue is #157

Notes

This PR introduces access control improvements for user registration and user updates:

  • Restricts access to the register user endpoint by adding the get_current_active_superuser dependency.
    -> Now, only superusers can register new users.Otherwise this endpoint was completely open before as specified in issue Auth: 2FA Authentication #157

@nishika26 nishika26 self-assigned this Jun 30, 2025
@nishika26 nishika26 added the bug Something isn't working label Jun 30, 2025
@nishika26 nishika26 moved this to In Progress in Dev Priorities Jun 30, 2025
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@nishika26 nishika26 changed the title authenticate endpoint and is superuser Auth : Only autheticated superuser allowed to register user Jun 30, 2025
@nishika26 nishika26 changed the title Auth : Only autheticated superuser allowed to register user Auth : Only autheticated superusers allowed to register user Jun 30, 2025
@nishika26 nishika26 marked this pull request as ready for review June 30, 2025 11:14
Copy link
Collaborator

@vijay-T4D vijay-T4D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link
Collaborator

@vijay-T4D vijay-T4D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@vijay-T4D vijay-T4D merged commit ceacb4c into main Jul 1, 2025
2 checks passed
@vijay-T4D vijay-T4D deleted the bug/register_user branch July 1, 2025 04:59
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Dev Priorities Jul 1, 2025
@nishika26 nishika26 changed the title Auth : Only autheticated superusers allowed to register user Auth : Only authenticated superusers allowed to register user Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

Auth: 2FA Authentication

3 participants