Skip to content

Conversation

@nishika26
Copy link
Collaborator

Summary

Target issue is #263
Explain the motivation for making this change. What existing problem does the pull request solve?

Now for start thread endpoint, the project id will get fetched from the api key being used to authenticate. Earlier it was fetching from request body even though the payload schema of this endpoint did not have project id as a parameter to accept.

@nishika26 nishika26 marked this pull request as ready for review July 3, 2025 07:18
@nishika26 nishika26 changed the title to get project id from api key Threads endpoint : get project id from api key Jul 3, 2025
@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
backend/app/api/deps.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@nishika26 nishika26 self-assigned this Jul 3, 2025
@nishika26 nishika26 added the bug Something isn't working label Jul 3, 2025
@nishika26 nishika26 moved this to In Progress in Dev Priorities Jul 3, 2025
Copy link
Collaborator

@vijay-T4D vijay-T4D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@AkhileshNegi AkhileshNegi merged commit 784c0b6 into main Jul 7, 2025
1 of 2 checks passed
@AkhileshNegi AkhileshNegi deleted the bug/threads_projectid branch July 7, 2025 08:38
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Dev Priorities Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready-for-review

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

Threads: start thread endpoint is not fetching "project_id" from anywhere

4 participants