Skip to content

Response API: Optimizing handling user context #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 8, 2025
Merged

Response API: Optimizing handling user context #267

merged 6 commits into from
Jul 8, 2025

Conversation

@avirajsingh7
Copy link
Collaborator

Summary

This PR updates the /responses and /responses/sync endpoints to remove project_id from the request body and instead use the project_id from the authenticated user (UserProjectOrg) dependency.

Target issue is #259

Checklist

Before submitting a pull request, please ensure that you mark these task.

  • Ran fastapi run --reload app/main.py or docker compose up in the repository root and test.
  • If you've fixed a bug or added code that is tested and has test cases.

@avirajsingh7 avirajsingh7 self-assigned this Jul 3, 2025
@avirajsingh7 avirajsingh7 added the enhancement New feature or request label Jul 3, 2025
@avirajsingh7 avirajsingh7 moved this to In Progress in Dev Priorities Jul 3, 2025
@codecov
Copy link

codecov bot commented Jul 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
backend/app/api/routes/responses.py 85.71% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@avirajsingh7 avirajsingh7 linked an issue Jul 3, 2025 that may be closed by this pull request
Remove project_id parameter from Response API – derive from API key #259
Closed
nishika26
nishika26 reviewed Jul 4, 2025
View reviewed changes
@avirajsingh7 avirajsingh7 force-pushed the enhc/remove_project_id branch from 60b2a61 to 2f517af Compare July 4, 2025 05:28
@avirajsingh7 avirajsingh7 requested a review from AkhileshNegi July 7, 2025 09:00
@AkhileshNegi AkhileshNegi changed the title Response API to take project_id from User Context instead of request payload Response API: Optimizing handling User Context Jul 8, 2025
@AkhileshNegi AkhileshNegi changed the title Response API: Optimizing handling User Context Response API: Optimizing handling user context Jul 8, 2025
@AkhileshNegi AkhileshNegi merged commit f51a27a into main Jul 8, 2025
1 of 2 checks passed
@AkhileshNegi AkhileshNegi deleted the enhc/remove_project_id branch July 8, 2025 06:49
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Dev Priorities Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkhileshNegi AkhileshNegi AkhileshNegi approved these changes

@nishika26 nishika26 nishika26 approved these changes

@vijay-T4D vijay-T4D Awaiting requested review from vijay-T4D

Assignees

@avirajsingh7 avirajsingh7

Labels

enhancement New feature or request ready-for-review

Projects

Dev Priorities
Status: Closed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove project_id parameter from Response API – derive from API key

3 participants

@avirajsingh7 @AkhileshNegi @nishika26