Skip to content

Conversation

@AkhileshNegi
Copy link
Collaborator

@AkhileshNegi AkhileshNegi commented Jul 31, 2025

Summary

Added fix for migration where in openai_assistant we add a non-nullable column without default value

Checklist

Before submitting a pull request, please ensure that you mark these task.

  • Ran fastapi run --reload app/main.py or docker compose up in the repository root and test.
  • If you've fixed a bug or added code that is tested and has test cases.

Summary by CodeRabbit

  • Chores
    • Updated database migration to set a default value of "false" for the "is_deleted" field in the assistant records. This ensures new assistants are not marked as deleted by default.

@AkhileshNegi AkhileshNegi self-assigned this Jul 31, 2025
@AkhileshNegi AkhileshNegi added the bug Something isn't working label Jul 31, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 31, 2025

Walkthrough

A database migration script was updated to set a server default value of "false" for the "is_deleted" Boolean column in the "openai_assistant" table. The addition of the "deleted_at" column and the downgrade logic remain unchanged.

Changes

Cohort / File(s) Change Summary
Alembic Migration Script
backend/app/alembic/versions/e8ee93526b37_add_is_deleted_column_in_assistant_table.py
Modified the upgrade function to add a server default value of "false" to the "is_deleted" Boolean column. No other changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A column now with "false" as base,
No more NULLs to chase or trace.
In tables deep, where data lies,
The rabbit hops with cheerful eyes.
A tiny tweak, a gentle nudge—
The schema’s safe, no need to judge!

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 223dc5b and a58e494.

📒 Files selected for processing (1)
  • backend/app/alembic/versions/e8ee93526b37_add_is_deleted_column_in_assistant_table.py (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
backend/app/alembic/versions/e8ee93526b37_add_is_deleted_column_in_assistant_table.py (1)
backend/app/alembic/versions/8eefcfedc409_create_assistant_table.py (1)
  • upgrade (20-40)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: checks (3.11.7, 6)
🔇 Additional comments (3)
backend/app/alembic/versions/e8ee93526b37_add_is_deleted_column_in_assistant_table.py (3)

24-26: LGTM! Nullable DateTime column for soft delete timestamp.

The deleted_at column follows the standard soft delete pattern - nullable DateTime to store when the record was soft deleted.


29-31: LGTM! Proper downgrade implementation.

The downgrade function correctly removes both columns in reverse order, ensuring clean rollback capability.


20-23: server_default format is valid for PostgreSQL backend

The application uses a PostgreSQL URI (postgresql+psycopg), so server_default="false" correctly renders DEFAULT false. No changes needed—this migration can be approved as-is.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/open-ai-migration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AkhileshNegi AkhileshNegi merged commit fcfc05f into main Jul 31, 2025
3 checks passed
@AkhileshNegi AkhileshNegi deleted the hotfix/open-ai-migration branch July 31, 2025 05:13
nishika26 pushed a commit that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants