-
Notifications
You must be signed in to change notification settings - Fork 5
Fix encoding issue by enforcing UTF-8 content type for transformed document uploads #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o include charset for markdown
WalkthroughThe content_type_map in execute_job was reduced to a single explicit mapping: "markdown" → "text/markdown; charset=utf-8". Previous explicit mappings for "text" and "html" were removed, causing non-markdown formats to default to "text/plain". Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
backend/app/core/doctransform/service.py
(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: AI Platform CI
backend/app/core/doctransform/service.py
[error] 1-1: Black formatting hook failed: file reformatted by Black. 1 file reformatted; please commit changes. Run 'pre-commit run --all-files' again or 'black backend/app/core/doctransform/service.py' to format.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Context
Changes Introduced
Updated content_type_map to include charset=utf-8 for markdown formats
Summary by CodeRabbit