fix(GODT-3124): Simplify locking in GPA server #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access to all the fake server state is now guarded by a single RWLock rather then multiple locks per category. It has been observed in the past that this could lead to deadlocks in Bridge unit tests at random.
jameshoulahan
approved these changes
Nov 24, 2023
cuthix
pushed a commit
to ProtonMail/proton-bridge
that referenced
this pull request
Dec 11, 2023
Update GPA to use the simplified locking model and hope that the problem solves itself. As far as I could tell, this might be a lock acquisition issue. ProtonMail/go-proton-api#132 ProtonMail/go-proton-api#133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access to all the fake server state is now guarded by a single RWLock rather then multiple locks per category. It has been observed in the past that this could lead to deadlocks in Bridge unit tests at random.