Skip to content

[Fix] Pause BFT block advancement during sync #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vicsn merged 42 commits into from
Mar 25, 2026
Merged

[Fix] Pause BFT block advancement during sync #4039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
42a8c2b
refactor(node/bft): use try_get for transmissions
kaimast Mar 3, 2026
c4ccf62
fix(node/bft): check if a transmission is aborted first during sync
kaimast Mar 3, 2026
25114de
fix(node/bft): treat missing transmissions as aborted during startup
kaimast Mar 6, 2026
ec298f1
misc(node/bft): remove ALLOW_LEDGER_ACCESS parameter
kaimast Dec 3, 2025
c026792
fix(bft/sync): pause bft block advancement during sync
kaimast Dec 3, 2025
f95a4d8
misc(node/bft): remove unnecessary `sync_lock`
kaimast Dec 24, 2025
c335e60
log(node/bft): print path of proposal cache if loading fails
kaimast Dec 24, 2025
cd77ac9
feat: print waiting tasks for locks as well
kaimast Jan 10, 2026
7323669
fix(node/bft): simplify sync commit path
kaimast Jan 12, 2026
44a484e
feat(node/bft): handle storage errors better
kaimast Jan 24, 2026
c266b3d
docs(node/bft): update README
kaimast Jan 24, 2026
bbe9cbd
docs(node/consensus): update README
kaimast Jan 24, 2026
cc87d33
fix(node/sync): handle outdated round numbers in subDAG
kaimast Jan 26, 2026
654100f
misc(node/bft): use proposal cache path given by NodeDataDir
kaimast Jan 29, 2026
53ee7f7
ci: enable reset tests for this branch
kaimast Feb 20, 2026
d64304c
feat(node/bft): explicitely track which sync mode the node is in
kaimast Feb 23, 2026
96f249c
logs(node/bft): minor improvements
kaimast Feb 26, 2026
4bd9960
misc(node/sync): time out block requests more agressively
kaimast Feb 26, 2026
9f88580
fix(node/sync): ensure not requests are issued to disconnecting peers
kaimast Feb 27, 2026
95007d1
fix(node/sync): handle failed block requests better
kaimast Feb 27, 2026
9d7ce52
refactor(node/sync): move try_issuing_block_requests to BlockSync
kaimast Feb 27, 2026
55501f5
fix(node/sync): do not disconnect on benign sync errors
kaimast Mar 2, 2026
7667638
fix(node/sync): ensure no requests are issued to disconnecting peers
kaimast Mar 9, 2026
e348c38
fix: only add certificates once at bootup
kaimast Mar 10, 2026
def2393
test(node/bft): check that storage records aborted transimissions cor…
kaimast Mar 10, 2026
81ce8d3
fix(node/sync): handle failed requests better
kaimast Mar 11, 2026
3fb8d10
misc(node/bft): remove unneeded async
kaimast Mar 11, 2026
2315e7c
fix(node): handle aborted transmissions properly during sync
kaimast Mar 11, 2026
3df8da5
misc(node): minor cleanups from code review
kaimast Mar 11, 2026
5fbdbbc
chore: cargo update
kaimast Mar 11, 2026
5ab60a5
refactor(node/bft): simplify sync_storage_with_ledger_at_bootup
kaimast Mar 12, 2026
952c192
fix(node/bft): do not unwrap() in Storage::new
kaimast Mar 13, 2026
b12f1ad
Merge remote-tracking branch 'origin/staging' into fix/sync-race-cond…
kaimast Mar 13, 2026
af65c9b
misc(node/sync): acquire the lock to failed requests less frequently
kaimast Mar 13, 2026
ed71c56
Merge remote-tracking branch 'origin/staging' into fix/sync-race-cond…
kaimast Mar 17, 2026
bdcd668
Merge remote-tracking branch 'origin/staging' into fix/sync-race-cond…
kaimast Mar 23, 2026
90e45be
fix(node/sync): do not attempt to sync when only one blcok behind
kaimast Mar 18, 2026
45e4724
fix(node/bft): handle benign errors in block sync better
kaimast Mar 18, 2026
06a5fd9
chore: run cargo update
kaimast Mar 23, 2026
75ed9bb
ci: do not delete ledger during restart majority test
kaimast Mar 23, 2026
b256267
fix(nodd/bft): hold DAG lock longer
kaimast Mar 17, 2026
e808114
test(node/bft): add simple tests for `DAG::is_linked`
kaimast Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .ci/test_restart_majority.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ start=$(now)

# Start all validator nodes in the background
for validator_index in $(seq 0 $((total_validators-1))); do
snarkos clean "--dev=$validator_index" "--network=$network_id" --keep-node-data

run_with_prefix "validator-$validator_index" snarkos start "${common_flags[@]}" "--dev=$validator_index" --validator --logfile="$log_dir/validator-$validator_index.log"
PIDS[validator_index]=$!
log "Started validator $validator_index with PID ${PIDS[$validator_index]}"
Expand Down
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@ workflows:
filters:
branches:
only:
- prevent_block_response_race_disconnect
- fix/sync-race-conditions
- canary
- testnet
- mainnet
Expand All @@ -798,7 +798,7 @@ workflows:
filters:
branches:
only:
- prevent_block_response_race_disconnect
- fix/sync-race-conditions
- canary
- testnet
- mainnet
Expand Down
Loading