Skip to content

Conversation

@PsiACE
Copy link
Owner

@PsiACE PsiACE commented Oct 10, 2025

  • introduce a unified router builder that lets agent/client handlers
    register request/notification methods declaratively, replacing bespoke
    dispatch logic
  • reorganize connection internals around message queue, state store,
    dispatcher, and sender components for clearer responsibilities and easier
    injection
  • add optional logfire/OpenTelemetry span instrumentation via span_context,
    wrapping request and notification execution without requiring
    configuration
  • simplify supporting modules and remove legacy handlers while keeping
    existing tests (tests/test_rpc.py, tests/real_user) passing

This PR was primarily authored with GPT-5-Codex and hand-reviewed by me. I’m responsible for every change that lands here.

Signed-off-by: Chojan Shang <chojan.shang@vesoft.com>
Signed-off-by: Chojan Shang <chojan.shang@vesoft.com>
Signed-off-by: Chojan Shang <chojan.shang@vesoft.com>
Signed-off-by: Chojan Shang <chojan.shang@vesoft.com>
Signed-off-by: Chojan Shang <chojan.shang@vesoft.com>
Signed-off-by: Chojan Shang <chojan.shang@vesoft.com>
@phil65
Copy link

phil65 commented Oct 11, 2025

Cool. didnt test this yet, but the last commit already fixed the basic loop for me, I now have a fully functional python agent with filesystem client tools, terminal client tools, MCP support (including MCP -> ACP progress reporting) working.
Do you think that router system really improves things? Not really a fan of getattr magic...

@PsiACE
Copy link
Owner Author

PsiACE commented Oct 11, 2025

but the last commit already fixed the basic loop for me

Glad the patch works for you—that was exactly why I shipped 0.4.5 yesterday after another user reported the issue.

Do you think that router system really improves things? Not really a fan of getattr magic...

As for the router: it’s mostly syntactic sugar to make handlers less painful. I get that the getattr-style magic isn’t everyone’s favorite. I’m considering a cleaner, more explicit approach and open to suggestions

@PsiACE PsiACE merged commit 1839086 into main Oct 11, 2025
6 checks passed
@PsiACE PsiACE deleted the style branch October 11, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants