Merged
Conversation
jboetticher
approved these changes
May 3, 2023
Contributor
There was a problem hiding this comment.
I'm approving this, but I think that you could make a helper function since the same logic seems to be repeating:
export async function getXCMVersion(api) {
// Get XCM Version - Not great but there is no chain state approach
const xcmpQueueVersion = (await api.query.xcmpQueue.palletVersion()) as any;
const xcmSafeVersion = (await api.query.polkadotXcm.safeXcmVersion()) as any;
const xcmVersion = `V${Math.max(xcmpQueueVersion, xcmSafeVersion).toString()}`;
// Get XCM Versioned Multilocation Type
const isV3 = xcmVersion === "V3";
const xcmType = isV3 ? "XcmV3MultiLocation" : "XcmV1MultiLocation";
return [xcmVersion, isV3, xcmType];
}
Collaborator
Author
|
@jboetticher I did my function without noticing you provided one haha. Anyways I implemented it. Did not use I'll merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably some work still needed as this will change with the next runtime