Skip to content

Added /open command #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Aug 23, 2022
Merged

Added /open command #37

merged 28 commits into from
Aug 23, 2022

Conversation

@XyrenTheCoder
Copy link
Collaborator

@XyrenTheCoder XyrenTheCoder commented May 6, 2022 •
edited
Loading

Need help on the "real code", I only got the idea up there, it's fine that if u don't want this u can just close this pr, because I understand that u want something new but I'm really out of ideas (remember to also delete the pr where I add the lootbox.json if u hav decided not to add this cmd)

@XyrenTheCoder
Being suck on creating a new cmd - open
0a30565 
Need help on the "real code", I only got the idea up there, it's fine that if u don't want this u can just close this pr, because I understand that u want something new but I'm really out of ideas
@XyrenTheCoder XyrenTheCoder added enhancement New feature or request help wanted Extra attention is needed labels May 6, 2022
@XyrenTheCoder
Copy link
Collaborator Author

There maybe some logical bugs so pls help aaaaaaaaaa

@XyrenTheCoder XyrenTheCoder marked this pull request as draft May 6, 2022 10:02
@XyrenTheCoder XyrenTheCoder requested a review from notsniped May 6, 2022 10:03
@XyrenTheCoder
Copy link
Collaborator Author

Or I would just pull from archie

notsniped
notsniped reviewed May 6, 2022
View reviewed changes
Copy link
Member

@notsniped notsniped left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be worked on

@notsniped notsniped added this to the Backlog milestone May 7, 2022
@notsniped
Copy link
Member

/open command will be converted to /use to reduce ux complexity.

@XyrenTheCoder
Copy link
Collaborator Author

/open command will be converted to /use to reduce ux complexity.

ok

@notsniped
Refine description and exception returns
b72ce37 
Also removed some unnecessary indents.
@notsniped
Copy link
Member

I'm leaving the 2 commands separate (/open for lootboxes and /use for general items), I just don't have an idea to combine them

notsniped added 2 commits May 20, 2022 09:36
@notsniped
Add return after every exception
fee7a6a 
Also indents had to be added back due to necessity
@notsniped
Make coin rewards for all 3 lootboxes
7207908
@notsniped notsniped marked this pull request as ready for review June 28, 2022 15:48
@notsniped
Copy link
Member

Wait why does this auto-resolve conflicts?

@notsniped notsniped marked this pull request as draft July 5, 2022 16:14
@notsniped notsniped added the delay/to-do Will be worked on later label Jul 28, 2022
@notsniped notsniped changed the title Being suck on creating a new cmd - open Added /open command Aug 4, 2022
@notsniped notsniped added area:currency framework Any updates, changes, or removals to the currency framework area:main Changes to the main functioning code labels Aug 7, 2022
@pull-request-size pull-request-size bot added size/S and removed size/M labels Aug 16, 2022
@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 23, 2022
@notsniped notsniped marked this pull request as ready for review August 23, 2022 15:23
@notsniped notsniped self-assigned this Aug 23, 2022
@notsniped notsniped self-requested a review August 23, 2022 15:25
notsniped
notsniped approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@notsniped notsniped left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

@notsniped notsniped removed the delay/to-do Will be worked on later label Aug 23, 2022
@notsniped notsniped modified the milestones: Backlog, Currency framework Aug 23, 2022
@notsniped notsniped merged commit f451f2f into main Aug 23, 2022
@notsniped notsniped deleted the archisha69-open branch August 23, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notsniped notsniped notsniped approved these changes

Assignees

@notsniped notsniped

Labels

area:currency framework Any updates, changes, or removals to the currency framework area:main Changes to the main functioning code enhancement New feature or request help wanted Extra attention is needed size/M

Projects

None yet

Milestone

Currency framework

Development

Successfully merging this pull request may close these issues.

2 participants

@XyrenTheCoder @notsniped