Skip to content

Debloat source code #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 4, 2022
Merged

Debloat source code #77

merged 16 commits into from
Aug 4, 2022

Conversation

@nickoncrack
Copy link
Contributor

no comment just read main.py

@nickoncrack
Copy link
Contributor Author

nickoncrack commented Jun 23, 2022 •
edited
Loading

merge/close/delete whatever its called i just want to delete fork

@nickoncrack nickoncrack reopened this Jun 23, 2022
@notsniped notsniped added debloat Remove extra crap from the source code area:main Changes to the main functioning code labels Jun 24, 2022
notsniped
notsniped reviewed Jun 24, 2022
View reviewed changes
@notsniped
Copy link
Member

Some parts of code look old, I'll give it a look

notsniped
notsniped reviewed Jun 24, 2022
View reviewed changes
main.py
if (chance <= 50):
x:int = random.randint(5000, currency['wallet'][str(user.id)])
if currency['wallet'][str(user.id)] < 5000: return await ctx.reply('They has less than 5000 coins on them. Don\'t waste your time...')
elif currency['wallet'][str(ctx.author.id)] < 5000: return await ctx.reply('You have less than 5k coins in your wallet. Play fair dude.') #what..? wheres logic?? i mean irl you can rob someone without havin any money at all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, robbing someone without having any money is possible, but there also has to be a failure penalty. If it was still 5000 coins from wallet, then the user would be in "debt"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if wallet == 0: return
else: random.randint(round(wallet/10, 0), wallet)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try it with this too. Lets see what works

notsniped
notsniped requested changes Jun 24, 2022
View reviewed changes
Copy link
Member

@notsniped notsniped left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From line 562 - line 566: Please re-check the keys and choices again, I will attempt to fix later. resolved
Line 610: Changes will probably be remade for /echo resolved

@notsniped notsniped changed the title -302 lines (i died of bloat) Debloat source code Jun 24, 2022
@nickoncrack
Copy link
Contributor Author

help what does changes requested mean i dont speak github

@notsniped
Copy link
Member

Meaning you have to make changes to the code to merge the pull request
However, I have already worked them out

@notsniped notsniped self-requested a review June 25, 2022 06:21
@notsniped
Copy link
Member

My debug environment is not working, so I am keeping this pull request on hold.

@notsniped notsniped added this to the Backlog milestone Jun 25, 2022
@notsniped notsniped self-requested a review July 3, 2022 16:23
@notsniped notsniped mentioned this pull request Jul 5, 2022
Closed
17 tasks
@notsniped
Copy link
Member

I am probably moving some parts of this pull request to smaller PR's so that I can work on these easily

@notsniped notsniped mentioned this pull request Jul 6, 2022
Merged
@nickoncrack
Copy link
Contributor Author

what is going on help i dfont speak githb

@notsniped
Copy link
Member

what is going on help i dfont speak githb

I just mentioned this pull request in another pull request

@XyrenTheCoder
Copy link
Collaborator

XyrenTheCoder commented Jul 7, 2022 via email

@nickoncrack nickoncrack reopened this Jul 30, 2022
@nickoncrack
Copy link
Contributor Author

bro wtf i clicked close instead of comment again

@notsniped
Copy link
Member

chokes

@notsniped
Copy link
Member

oh my, i made this pill request more than amonth ago and its still open

I'm only now checking and debugging the code XD

@notsniped notsniped self-requested a review July 31, 2022 04:29
@nickoncrack
Copy link
Contributor Author

chokes

that doesnt look very professional to me, you are on github m8
🤨

@XyrenTheCoder
Copy link
Collaborator

chokes

that doesnt look very professional to me, you are on github m8 raised_eyebrow

o k i guess (suddenly cosine when i typed "k")

@nickoncrack
Copy link
Contributor Author

chokes

that doesnt look very professional to me, you are on github m8 raised_eyebrow

o k i guess (suddenly cosine when i typed "k")

kosine

@notsniped
Copy link
Member

chokes

that doesnt look very professional to me, you are on github m8 raised_eyebrow

unchokes

notsniped
notsniped reviewed Aug 2, 2022
View reviewed changes
notsniped
notsniped reviewed Aug 2, 2022
View reviewed changes
main.py Outdated
if (chance <= 20):
x:int = random.randint(10000, currency['wallet'][str(user.id)])
if currency['wallet'][str(user.id)] < 10000: return await ctx.reply('You really want to risk losing your life to a poor person? (imagine robbing someone with < 10k net worth)')
elif currency['wallet'][str(ctx.author.id)] < 5000: return await ctx.reply('You have less than 10k in your wallet. Don\'t be greedy.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the value to 10000, it should not be 5000

@nickoncrack
Copy link
Contributor Author

nvm merge takes insanely long

@nickoncrack nickoncrack closed this Aug 2, 2022
@notsniped
Copy link
Member

I was just busy with exams, you know

@notsniped
Copy link
Member

Ok I'm back to checking, I guess

@notsniped notsniped reopened this Aug 4, 2022
notsniped
notsniped reviewed Aug 4, 2022
View reviewed changes
main.py
currency['wallet'][str(ctx.author.id)] -= 2000
save()
await ctx.reply('YOU FELL INTO YOUR OWN TRAP AND DIED LMFAO\nYou lost 2000 coins in the process.')
await ctx.reply('YOU FELL INTO YOUR OWN TRAP AND DIED LMFAO\nYou lost 2000 coins in the process.') #but you were digging??
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pov: you do a neck flip falling into the hole you dug

@notsniped
Copy link
Member

Finally ready to merge after a few days a few months

@notsniped notsniped merged commit 246588f into PyBotDevs:main Aug 4, 2022
@nickoncrack
Copy link
Contributor Author

nickoncrack commented Aug 5, 2022 •
edited
Loading

oih damn that was unexpcreg

edit: oh*
exit 2: unexpected*
edit 3; edit*

@notsniped
Copy link
Member

I went grind mode

@notsniped
Copy link
Member

oih damn that was unexpcreg

edit: oh* exit 2: unexpected* edit 3; edit*

edit 4: :*

@nickoncrack
Copy link
Contributor Author

oih damn that was unexpcreg
edit: oh* exit 2: unexpected* edit 3; edit*

edit 4: :*

IGUDEBWNSODFIPBMPWEIOMBFPOISMDSKMGBWLFBM;DF/V

@notsniped
Copy link
Member

L

notsniped added a commit that referenced this pull request Aug 6, 2022
@notsniped
Roll back db key handler to old version
7c54d19 
Rolled back to version before #77
@notsniped notsniped mentioned this pull request Aug 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notsniped notsniped notsniped approved these changes

Assignees

@notsniped notsniped

Labels

area:main Changes to the main functioning code debloat Remove extra crap from the source code priority:medium size/XL

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@nickoncrack @notsniped @XyrenTheCoder