Made list of property-like decorators configurable. #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to configure pylint to accept custom decorators similar to @Property without the need to explicitly add a pylint directive #pylint disable=invalid-name
pylint/checkers/base.py
Outdated
| :param config: Configuration from which to pull additional property classes. | ||
| :returns: One of ('function', 'method', 'attr') | ||
| """ | ||
| property_classes = set((BUILTIN_PROPERTY,)) |
Contributor
There was a problem hiding this comment.
Can you move this small block into a private function, which returns a tuple of property classes and names?
Contributor
Author
|
Thanks for the feedback ! I think I addressed your comments. |
Contributor
|
Gets a 👍 from me! |
Contributor
|
Hey @yannack Mind adding yourself to CONTRIBUTORS, as well adding a new entry in the Changelog with this new option? After that, we could merge this. |
Contributor
Author
|
Hi, |
Contributor
|
All good, thanks! |
PCManticore
pushed a commit
that referenced
this pull request
Jul 2, 2016
Made list of property-like decorators configurable. This makes it possible to configure pylint to accept custom decorators similar to @Property without the need to explicitly add a pylint directive #pylint disable=invalid-name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / new features
This makes it possible to configure pylint to accept custom decorators
similar to @Property without the need to explicitly add a pylint
directive #pylint disable=invalid-name