Skip to content

Conversation

@sqwishy
Copy link
Contributor

@sqwishy sqwishy commented Sep 5, 2018

Also doing the exclusive thing properly in openbin.

(#182)

I think the OS_RDWR behaviour is correct since if you specify x mode, you can't specify r or w. So it implies both. I'm pretty sure this is what Python 3 does so the fs package API should be consistent in both versions of Python here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.754% when pulling cc96670 on sqwishy:rdwr-exclusive into cd1a973 on PyFilesystem:master.

@willmcgugan
Copy link
Member

Thanks!

@willmcgugan willmcgugan merged commit 1a1ed3f into PyFilesystem:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants