Win fix #269
Merged
Win fix #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
althonos
reviewed
Feb 23, 2019
| for info in test_fs.scandir("/"): | ||
| self.assertIsInstance(info.name, six.text_type) | ||
| self.assertEqual(info.name, self.TEST_FILENAME_UNICODE) | ||
| if platform.system() != "Windows": |
There was a problem hiding this comment.
Why not wrap in two unittest.skipIf decorators with two different conditions ?
There was a problem hiding this comment.
It was breaking at the module level. Fsencode uses 'strict' error handler and was throwing an exception on the classvar.
There was a problem hiding this comment.
No worries! I've got Windows tests running with appveyor now, so we can catch these things in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Fixes #256 and a number of other Windows issues. Now that we have Windows set up in appveyor, we can keep on top of Windows support