Skip to content

fix fs.path import #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2019
Merged

fix fs.path import #316

merged 3 commits into from
Jul 28, 2019

Conversation

willmcgugan
Copy link
Member

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Fix for #304

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 97.943% when pulling c783f35 on fix-path-import into 3723642 on master.

@willmcgugan willmcgugan merged commit 0631416 into master Jul 28, 2019
@willmcgugan willmcgugan deleted the fix-path-import branch July 28, 2019 15:41
@lurch
Copy link
Contributor

lurch commented Jul 30, 2019

@willmcgugan This seems to have broken the Travis builds for Python 2.7 and Python 3.4 ?

@felixonmars
Copy link
Contributor

Python 2.7 test suite is broken here too.

@willmcgugan
Copy link
Member Author

I'll file an issue.

@willmcgugan willmcgugan mentioned this pull request Aug 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@willmcgugan @coveralls @lurch @felixonmars