typing fixes #334
Merged
typing fixes #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
commented
Aug 4, 2019
| except ImportError: | ||
|
|
||
| def fspath(path): | ||
| def fspath(path): # type: ignore |
There was a problem hiding this comment.
mypy complains about redefinition
willmcgugan
commented
Aug 4, 2019
| # type: () -> None | ||
| self.root = None | ||
| if not self._closed: | ||
| del self.root |
There was a problem hiding this comment.
Mypy complains when assigning None, rather than modify the type of root just del it.
willmcgugan
commented
Aug 4, 2019
| return os.readlink(sys_path) | ||
| else: | ||
| target = os.readlink(fsencode(sys_path)) | ||
| return fsdecode(os.readlink(fsencode(sys_path))) |
There was a problem hiding this comment.
The link target was returned as bytes. A genuine bug uncovered by Mypy. Thanks, Mypy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Fixing typing related issues