Use unittest.SkipTest instead of pytest.skip in fs.test
#354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @althonos |
Contributor
|
@willmcgugan Not related to this PR directly, but Travis seems to be failing on "Type checking" ? |
Member
|
Yeah, noticed that. Not sure why that popped up since it was passing previously. Will take a look at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Description
Hi Will!
Just a quick bugfix since switching to
pytestbroke the CI offs.sshfsandfs.smbfs, as I am not usingpytestfor these 😃Instead of using
pytest.skip, raisingunittest.SkipTestwill be recognized in bothpytestand non-pytesttest harnesses, sinceunittestis pretty much the standard as it is part of the standard library.