None docstrings fix #414
Merged
None docstrings fix #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support "__doc__" being set to `None`, as is done when `-OO` is supplied to the CPython interpreter.
lurch
reviewed
Jul 30, 2020
Simplify if statement condition
althonos
requested changes
Sep 17, 2020
Member
althonos
left a comment
althonos
left a comment
There was a problem hiding this comment.
Good job, thanks! Just waiting for you to revert changes on the fs._version file and then I'll merge. Can you add yourself to the CONTRIBUTORS.md file as well if possible?
Revert version bump since it is done as part of the merge/release process.
Add self & maintain alphabetical order.
Contributor
Author
|
Reverted the version bump & added myself to the contributors. 👍 |
althonos
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Fixes an issue when docstrings are set to
None. Issue #415.