-
Notifications
You must be signed in to change notification settings - Fork 121
Add new resources to pylabrobot #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new resources to pylabrobot #574
Conversation
can you share a picture of the plate/trough and the carrier? |
|
also could you please add it to the resource library docs? part number/name/image/manufacturer website. see existing resources for examples |
|
if you referenced technical drawings (ideal), please link them if you measured some attributes, please add a |
@maraxen are the reagent reservoirs we currently have on the carrier the same as the vwr 96 channel reagent reservoir? |
nevermind the two reservoirs are definitely different |
|
(added a tutorial for posterity: #576, will be live in the docs in ~30 min) |
|
we have historically modeled these resources as single-well plates. see they can only be used on what we call "plate carriers" (you are right - what constitutes a "trough carrier" is a little ambiguous right now.) perhaps in the future we will model these are troughs, but for now let's be consistent with the existing code |
|
would be great to link in your code :) |
…vwr_96_channel_reservoir
…n04/pylabrobot into vwr_96_channel_reservoir
|
Comments addressed, let me know if i missed anything! |
| num_items_x=12, # from spec | ||
| num_items_y=8, # from spec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be 1, 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought num_items_x and num_items_y refer to the number of wells in the x and y direction - 12 x 8 wells should get us the 96 wells
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what Rick was calling attention to is that since it is reservoir, it is essentially a single well plate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to
num_items_x=1
num_items_y=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rickwierenga just a quick question about num_items_x and num_items_y - the vwr plate does have 96 different wells, so setting num_items_x and num_items_y to 1 won't let me use aspirate96 - see picture below
could you explain a little bit about why it should be represented as a single well plate - im new the wet lab work so apologies if this is a naive question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the plate in the image, it is num_items_x = 12, num_items_y = 8 because they are clearly 8x12 wells.
this seems to be a different plate from the technical drawing above, which has one big well (with 96 drain points)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, i'll double check with @maraxen about this and confirm the plate specifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. it's possible you're talking about two separate plates i think :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they are two different plates. Eric will add both and hopefully we can merge
|
given that there was an import error and the code didn't run at all, i would like to ask: have you tested this plate definition and verified it works? i just fixed the errors and updated it to adhere to the PLR plate naming convention |
|
the see the original PlateAdapter PR #152 for more information. |
my apologies, will test before submitting -- initial reason for this PR was to get thoughts on the implementation, but probably should've opened an issue instead |
|
no worries, just making sure we keep a high code quality on plr:main in the future, for discussions feel free to go to discuss.pylabrobot.org or create a draft PR :) |
what does site_pedestal_z represent? i couldn't find anything about it in PR #152 |
Thank you for catching this, this is a mistake I've made. This attribute is best explained with examples: Some PlateAdapters have a central elevation but surrounding it they have a thin metal plate, enabling them to fit onto an SLAS format plate holder. This attributes captures the thickness of that metal plate at the every bottom. Other PlateAdapters like the Alpaqua magnets are straight away in SLAS footprint format, so they don't need it. But thinking about the fact that this attributes is not used at all and the PlateAdapter definition works really well, I propose removing it altogether. And only use plate_adapter.dz - at runtime! - to define where H1 of a well would go. Note: this has to be defined/overwritten at runtime because every plate and PlateAdapter have different well/hole shapes. We cannot model all possible combinations. Therefore overwriting at runtime is necessary. |
|
removing in #582 |
|
thanks @BioCam for quick response @ericguan04 feel free to sync plr:main into your branch and drop the site_pedestal_z |
…vwr_96_channel_reservoir
|
@rickwierenga added vwr deep well plate, and fixed vwr reservoir + sergi plate adapter. Testing code below: code above ran with no errors --> please check anything else i might've missed, and let me know if there are any formatting issues with the names - thanks! |
|
thank you for contributing these resources! some small changes i made:
|




Adding Sergi Lab Magnet Rack and VWR reagent reservoirs.
How should we handle the case where we want the resource to inherit from both Plate and Trough? This is because VWR reagent reservoir dimensions are pretty much plates, but could also be classified as a trough for liquid storage. Issue arises when we want to add the resource to plate/trough carrier or stack - has to be one or the other.
Added vwr to both plates.py and troughs.py, but there could be a more robust way to implement this. Would love to hear your thoughts / ideas!