Skip to content

Fix abstract class detection #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025
Merged

Fix abstract class detection #598

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
392ca0e
Fix abstract class check in MachineBackend
rickwierenga Jul 16, 2025
b6367b6
Update backend.py
rickwierenga Jul 16, 2025
920fab8
Update backend.py
rickwierenga Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pylabrobot/machines/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import inspect
import weakref
from abc import ABC, ABCMeta, abstractmethod
from abc import ABC, abstractmethod

from pylabrobot.utils.object_parsing import find_subclass

Expand Down Expand Up @@ -29,7 +30,7 @@ def deserialize(cls, data: dict):
subclass = find_subclass(class_name, cls=cls)
if subclass is None:
raise ValueError(f'Could not find subclass with name "{data["type"]}"')
if issubclass(subclass, ABCMeta):
if inspect.isabstract(subclass):
raise ValueError(f'Subclass with name "{data["type"]}" is abstract')
assert issubclass(subclass, cls)
return subclass(**data)
Expand Down