Cytation focus inner 50% of image #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cytation sensor actually sends a lot more data than is visible in gen5.exe
probably because there is a vignette effect going on and the other edges aren't as clear
i think it's the user's responsibility to filter out data. it is better to give them more data/ freedom than lose it prematurely
however, for autofocus this can sometimes mean the algorithm picks up strange details along the edges, not the inner part that we actually care about
this PR changes that by cropping the images to the inner 50% and just auto-focusing on that
it works very well in my testing
in the future it might be an option if there is a need for this, but it seems a very powerful default so i will make this main right now