Fix request_iswap_rotation_drive_orientation
#669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why not make PARKED_RIGHT part of the enum? |
Collaborator
Author
Can do but if it is part of the enum one would expect it to work the same way as the other enums... but that is not the case - when used with |
Member
|
We can raise an error in that case |
| auto_id=False, | ||
| wp=orientation.value, | ||
| ) | ||
| if orientation.value: |
Member
There was a problem hiding this comment.
Why base this on the enum value? It is very implicit. Also the enum values typically don't matter. It would better to check
if orientation in {not, allow}:
raise
...
Collaborator
Author
There was a problem hiding this comment.
The enum values are the reason for the existence of the enums, I thought? The vallues are what the firmware requires as input as in the example you highlighted.
We can of course make it more explicit though
BioCam
deleted the
Fxi-`request_iswap_rotation_drive_position_increments`
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.