STAR iswap & channel 0 collision checks #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickwierenga
force-pushed
the
STARBackend.move_iswap_y_relative-safety-check
branch
from
4a957a2 to
d09962d
Compare
Member
Author
|
rickwierenga
changed the title
STARBackend.move_iswap_y_relative channel 0 collision check
rickwierenga
deleted the
STARBackend.move_iswap_y_relative-safety-check
branch
BioCam
reviewed
Oct 1, 2025
| mm_per_increment = 0.046302083 | ||
| return round(y_inc * mm_per_increment, 2) | ||
|
|
||
| async def iswap_request_module_y(self) -> float: |
Collaborator
There was a problem hiding this comment.
This is a duplication and already exists in PyLabRobot since #666
Member
Author
There was a problem hiding this comment.
thanks, I forgot this exists
| ) | ||
|
|
||
| @staticmethod | ||
| def _iswap_y_inc_to_mm(y_inc: int) -> float: |
Collaborator
There was a problem hiding this comment.
This is a duplication as well, and has existed in PyLabRobot as y_drive_increment_to_mm for a while
Member
Author
There was a problem hiding this comment.
I thought this is for pip channels, but the conversion is actually the same
rickwierenga
added a commit
that referenced
this pull request
Oct 1, 2025
This reverts commit 0bd219f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.