star: error if grip direction is not front (default) with core gripper #751
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickwierenga
added a commit
to Cheshire-Labs/pylabrobot
that referenced
this pull request
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the direction is meaningless so let's conventionally set it to FRONT with core grippers. direction is most important for resource rotations, which is impossible with the core grippers
however, the front end does not know that and will still apply the rotation (if directions are specified). this leads to placement errors
in this PR I fix that error case by conventionally setting core grippers as "front" pickup to avoid mistaken rotation issues (might be
Noneor sth if we refactor in the future, but that's annoying with the standard API)