Skip to content

Conversation

@mrava87
Copy link
Contributor

@mrava87 mrava87 commented Jun 24, 2025

This PR adds a new directory called tutorials_cupy which includes tutorials running with CuPy arrays and MPI communicators.

Following what previously done for tutorials_nccl, a couple of new targets are also added to the Makefile to allow building the documentation with MPI or MPI/Cupy+MPI or MPI/CuPy+MPI/CuPy+NCCL tutorials.

@mrava87 mrava87 requested a review from rohanbabbar04 June 25, 2025 20:44
Copy link
Collaborator

@rohanbabbar04 rohanbabbar04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using rank % device_count seems appropriate, as it allows flexibility in the number of ranks without requiring an equal number of GPUs.

Otherwise, it looks great—let me know if you agree with me 🙂

@mrava87
Copy link
Contributor Author

mrava87 commented Jun 28, 2025

Using rank % device_count seems appropriate, as it allows flexibility in the number of ranks without requiring an equal number of GPUs.

Otherwise, it looks great—let me know if you agree with me 🙂

Thank @rohanbabbar04! Yes, I agree, that is a good point 😄 I am going to do give quick look at all the tutorials and then merge

mrava87 and others added 3 commits June 28, 2025 17:38
Co-authored-by: Rohan Babbar  <rohanbabbar0408@yahoo.com>
Co-authored-by: Rohan Babbar  <rohanbabbar0408@yahoo.com>
Co-authored-by: Rohan Babbar  <rohanbabbar0408@yahoo.com>
@mrava87 mrava87 merged commit da326a0 into PyLops:main Jun 29, 2025
61 checks passed
@mrava87 mrava87 deleted the doc-cupy branch June 29, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants