Mark Element unsafe
#213
Merged
Mark Element unsafe
#213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
reviewed
Nov 5, 2021
| /// Represents that a type can be an element of `PyArray`. | ||
| pub trait Element: Clone + Send { | ||
| /// | ||
| /// A type `T` that implements this trait should be safe when managed in numpy array, |
Member
There was a problem hiding this comment.
I think adding the header
/// # Safety
before this section would be good so that Clippy's missing_safety_doc is appeased.
Member
Author
There was a problem hiding this comment.
Thanks! Could you please take a glance at the revised version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #207