Fix ntasks job option,work_dir job option and slurmdb_jobs db connection #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
It seems that the master branch already failed in the same steps. |
giovtorres
reviewed
Jul 19, 2019
| cwd = os.getcwd().encode("UTF-8", "replace") | ||
| desc.work_dir = cwd | ||
|
|
||
| if job_opts.get("work_dir"): |
giovtorres
reviewed
Jul 19, 2019
| dict J_dict = {} | ||
| slurm.List JOBSList | ||
| slurm.ListIterator iters = NULL | ||
| void* db_conn = slurm.slurmdb_connection_get() |
Member
There was a problem hiding this comment.
👍 I can't remember if this got taken out or was missing to begin with.
giovtorres
reviewed
Jul 19, 2019
| # TODO: ntasks_set, cpus_set | ||
|
|
||
| if job_opts.get("ntasks"): | ||
| desc.min_cpus = job_opts.get("ntasks") * job_opts.get("cpus_per_task") |
Member
There was a problem hiding this comment.
Is this right? I think there's some conditions to calculating min_cpus.
Member
|
The Python 2.6 tests need to get fixed. 😞 |
Member
|
Can you rebase please? |
Member
|
No response. Please rebase. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have edited pyslurm.pyx file to fix the ntasks job option which was commented out, fix the work_dir job option which was not implemented and to fix slurmdb_jobs_get() database connection issue. There was no statement to close the database connection after fetching data, and as a result, the function was unable to fetch changes to the database running on flask server.