Skip to content

Fix various small issues #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 4, 2019
Merged

Fix various small issues #215

merged 8 commits into from
May 4, 2019

Conversation

@bact
Copy link
Member

@bact bact commented May 3, 2019 •
edited
Loading

  • fix/add return type hinting for functions in pythainlp.corpus
  • fix deprecated inline flag for regular expression in TNC
  • add more test cases for thai_strftime()
  • add test for Python 3.7 (appveyor) + update PyICU to 2.3.1

@pep8speaks
Copy link

pep8speaks commented May 3, 2019 •
edited
Loading

Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 580:80: E501 line too long (85 > 79 characters)

Comment last updated at 2019-05-04 18:13:53 UTC

@coveralls
Copy link

coveralls commented May 3, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 87.37% when pulling 1f56415 on bact:dev into e9a300b on PyThaiNLP:dev.

@bact bact changed the title add return type Fix various small issues May 4, 2019
@bact bact merged commit 277d4a4 into PyThaiNLP:dev May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bact @pep8speaks @coveralls