Skip to content

Move dill to pickle #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 21, 2020
Merged

Move dill to pickle #408

merged 7 commits into from
May 21, 2020
+64 −72

Conversation

@wannaphong
Copy link
Member

@wannaphong wannaphong commented May 21, 2020

This pull request fixed #405

@bact
Copy link
Member

bact commented May 21, 2020

Standard file extension for pickle is .pkl. May be renaming the files?

@bact
Copy link
Member

bact commented May 21, 2020

Also remove dill from requirements.txt

@wannaphong
Copy link
Member Author

wannaphong commented May 21, 2020

Also remove dill from requirements.txt

Done

@coveralls
Copy link

coveralls commented May 21, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 91.093% when pulling 392670c on move-dill2pickle into a4bbac9 on dev.

@bact
Copy link
Member

bact commented May 21, 2020 •
edited
Loading

Does the tagger still working correctly / similar to when it was using dill?

Looks like at least it pass one test at

pythainlp/tests/test_tag.py

Line 49 in a4bbac9

self.assertEqual(

But just to confirm.

@bact bact added the refactoring a technical improvement which does not add any new features or change existing features. label May 21, 2020
@bact bact added this to the 2.2 milestone May 21, 2020
bact added 2 commits May 21, 2020 16:50
@bact
Add pos_tag test case
0dba35e
@bact
Merge pull request #410 from PyThaiNLP/rm-dill
392670c 
Add pos_tag test case

To follow up in branch move-dill2pickle
@wannaphong
Copy link
Member Author

wannaphong commented May 21, 2020

Does the tagger still working correctly / similar to when it was using dill?

Looks like at least it pass one test at

pythainlp/tests/test_tag.py

Line 49 in a4bbac9

self.assertEqual(

But just to confirm.

It's working correctly.

@bact bact merged commit 37fd7da into dev May 21, 2020
@wannaphong wannaphong deleted the move-dill2pickle branch May 22, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

refactoring a technical improvement which does not add any new features or change existing features.

Projects

None yet

Milestone

2.2

Development

Successfully merging this pull request may close these issues.

[DEP] Remove dill dependency

4 participants

@wannaphong @bact @coveralls