Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Mar 21, 2022

What does this PR do?

  • Replace all latest with locked versions
  • In the CI we augment all requirements files by adding max version

To prepare the latest lock, run:

python .actions/assistant.py create_locked_versions

This can be also automated, to run this generation nightly, and if there is a diff, send slack msg or create PR

Does your PR introduce any breaking changes? If yes, please list them.

@awaelchli

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

os: [ubuntu-20.04, windows-2019, macOS-10.15]
python-version: ["3.7", "3.9"] # minimum, maximum
requires: ["oldest", "latest"]
requires: ["oldest", "locked"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
requires: ["oldest", "locked"]
requires: ["oldest", "recent"]

@@ -0,0 +1,26 @@
PyYAML: '6.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who will update these?
See the Notion doc for a suggestion how to keep them updated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this PR it is manual, but in the following PR we can add workflow weekly generating new/actual/latest versions and there is change, it will create PR to our repo...

@Borda Borda self-assigned this Apr 9, 2022
@Borda Borda marked this pull request as draft April 9, 2022 14:14
@rohitgr7 rohitgr7 deleted the ci/locked branch May 15, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants