-
Notifications
You must be signed in to change notification settings - Fork 3.6k
logic for lock requirements #12383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logic for lock requirements #12383
Conversation
for more information, see https://pre-commit.ci
| os: [ubuntu-20.04, windows-2019, macOS-10.15] | ||
| python-version: ["3.7", "3.9"] # minimum, maximum | ||
| requires: ["oldest", "latest"] | ||
| requires: ["oldest", "locked"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| requires: ["oldest", "locked"] | |
| requires: ["oldest", "recent"] |
| @@ -0,0 +1,26 @@ | |||
| PyYAML: '6.0' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
who will update these?
See the Notion doc for a suggestion how to keep them updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this PR it is manual, but in the following PR we can add workflow weekly generating new/actual/latest versions and there is change, it will create PR to our repo...
What does this PR do?
To prepare the latest lock, run:
This can be also automated, to run this generation nightly, and if there is a diff, send slack msg or create PR
Does your PR introduce any breaking changes? If yes, please list them.
@awaelchli
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @akihironitta @Borda