Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Apr 15, 2022

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

the original work taken from logic for lock requirements

  • setting upper bound for the latest version with locked ones
  • in the CI we augment all requirements files by adding max version

To prepare the latest lock, run:

python .actions/assistant.py create_locked_versions

This can be also automated, to run this generation nightly, and if there is a diff, send a slack msg or create a PR

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (7e3565d) to head (f869dda).
Report is 61 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #159   +/-   ##
===================================
- Coverage    73%    72%   -2%     
===================================
  Files         2      2           
  Lines       382    398   +16     
===================================
+ Hits        280    285    +5     
- Misses      102    113   +11     

@Borda Borda changed the title CI: freeze requirements CI: lock requirements & unfreeze Apr 15, 2022
@stale stale bot added the won't fix This will not be worked on label Jun 23, 2022
@Lightning-AI Lightning-AI deleted a comment from stale bot Jun 29, 2022
@stale stale bot removed the won't fix This will not be worked on label Jun 29, 2022
@Borda Borda self-assigned this Aug 15, 2022
@Borda Borda mentioned this pull request Jan 1, 2023
3 tasks
@Borda Borda force-pushed the main branch 2 times, most recently from d4acf6f to ac8f7ba Compare July 19, 2024 21:12
@Borda Borda added the won't fix This will not be worked on label Jul 19, 2024
@Borda Borda closed this in #336 Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request won't fix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant