Skip to content

Conversation

@Quantum-Codes
Copy link
Contributor

Summary

This PR fixes

  1. few mentions of "button" component mentions in select menu page
  2. Using inbuilt function self.disable_all_items() rather than manually looking though children.
  3. Fixes a 404 link in README for CONTRIBUTING.md

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Update buttons page to use an inbuilt feature to disable all buttons rather than manually looping through all the children.

Signed-off-by: Ankit_Anmol <87054411+Quantum-Codes@users.noreply.github.com>
Update Disabling code to use inbuilt functions rather than looping over all the children.

Signed-off-by: Ankit_Anmol <87054411+Quantum-Codes@users.noreply.github.com>
Change few button mentions to select menus

Signed-off-by: Ankit_Anmol <87054411+Quantum-Codes@users.noreply.github.com>
Signed-off-by: Ankit_Anmol <87054411+Quantum-Codes@users.noreply.github.com>
Signed-off-by: Ankit_Anmol <87054411+Quantum-Codes@users.noreply.github.com>
Signed-off-by: Ankit_Anmol <87054411+Quantum-Codes@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for pycord ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 08ab13e
🔍 Latest deploy log https://app.netlify.com/sites/pycord/deploys/6478756d57ee9c00089b7a0d
😎 Deploy Preview https://deploy-preview-332--pycord.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Ankit_Anmol <87054411+Quantum-Codes@users.noreply.github.com>
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lulalaby Lulalaby merged commit 5872d70 into Pycord-Development:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants